Skip to content

Fix Issues 6.4 Batch - #4202

Merged
nasbench merged 9 commits into
developfrom
fix-issues-6_4
Aug 5, 2026
Merged

Fix Issues 6.4 Batch#4202
nasbench merged 9 commits into
developfrom
fix-issues-6_4

Conversation

@nasbench

@nasbench nasbench commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

This PR fixes a couple of issues reported by the community through GH and E-mail, as well as a bunch of other issues identified by STRT.

@nasbench
nasbench marked this pull request as ready for review August 5, 2026 14:56
tccontre
tccontre previously approved these changes Aug 5, 2026

@tccontre tccontre left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread detections/endpoint/windows_user_discovery_via_net.yml

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates multiple Splunk Security Content detection YAMLs to address community/STRT-reported issues by improving analytic metadata readability, refining SPL searches, and expanding coverage (tests/references/technique mappings) in several endpoint detections.

Changes:

  • Reformats several analytics’ description, how_to_implement, and known_false_positives fields into block scalars for readability/consistency.
  • Refines SPL searches (e.g., IN (...) lists, AccessMask bit checks, updated exclusions) and updates finding/intermediate finding messages.
  • Expands coverage and context via additional references and (in at least one analytic) additional test cases / ATT&CK technique coverage.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
detections/endpoint/windows_user_discovery_via_net.yml Refactors SPL formatting, expands to include domain discovery context, adds additional ATT&CK mapping and test.
detections/endpoint/windows_registry_dotnet_etw_disabled_via_env_variable.yml Refactors SPL formatting and updates finding/intermediate finding messaging.
detections/endpoint/windows_disable_shutdown_button_through_registry.yml Refactors SPL formatting and improves intermediate finding message and references.
detections/endpoint/network_share_discovery_via_dir_command.yml Refactors SPL and adds AccessMask bit logic plus updated references.
detections/endpoint/high_frequency_copy_of_files_in_network_share.yml Refactors SPL and adds AccessMask bit logic; updates intermediate finding messaging.
detections/endpoint/executable_file_written_in_administrative_smb_share.yml Refactors SPL, expands targeted extensions, and updates finding title formatting and references.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread detections/endpoint/high_frequency_copy_of_files_in_network_share.yml Outdated
Comment thread detections/endpoint/executable_file_written_in_administrative_smb_share.yml Outdated
Comment thread detections/endpoint/network_share_discovery_via_dir_command.yml
Comment thread detections/endpoint/network_share_discovery_via_dir_command.yml Outdated
Comment thread detections/endpoint/windows_registry_dotnet_etw_disabled_via_env_variable.yml Outdated
Comment thread detections/endpoint/windows_disable_shutdown_button_through_registry.yml Outdated
@nasbench
nasbench requested a review from tccontre August 5, 2026 15:46

@tccontre tccontre left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@nasbench
nasbench requested a lite review from Copilot August 5, 2026 16:06

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.

Suppressed comments (2)

detections/endpoint/network_share_discovery_via_dir_command.yml:49

  • The known_false_positives text has a grammatical error ("administrations tasks"). This should be "administrative tasks" (or similar) for clarity.
known_false_positives: |-
    System Administrators may use tools like "net.exe", "net1.exe", or "dir" for troubleshooting or administrations tasks.
    However, this will typically come only from certain users and certain systems that can be added to an allow list.

detections/endpoint/executable_file_written_in_administrative_smb_share.yml:46

  • The known_false_positives text has a grammatical error ("administrations tasks"). This should be "administrative tasks" for clarity and professionalism.
known_false_positives: |-
    System Administrators may use tools like PsExec for troubleshooting or administrations tasks. However, this will typically come only from certain users and certain systems that can be added to an allow list.

@nasbench
nasbench merged commit 33064e8 into develop Aug 5, 2026
6 checks passed
@nasbench
nasbench deleted the fix-issues-6_4 branch August 5, 2026 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

3 participants