Fix Couchbase auditing for immutable entities, including Java records - #2151
Open
kaliy wants to merge 2 commits into
Open
Fix Couchbase auditing for immutable entities, including Java records#2151kaliy wants to merge 2 commits into
kaliy wants to merge 2 commits into
Conversation
Signed-off-by: Artur Kalimullin <kalimullin@gmail.com>
kaliy
force-pushed
the
fix-auditing-immutable-entities
branch
8 times, most recently
from
August 13, 2026 13:01
80f26fb to
b5ae278
Compare
Signed-off-by: Artur Kalimullin <kalimullin@gmail.com>
kaliy
force-pushed
the
fix-auditing-immutable-entities
branch
from
August 13, 2026 13:03
b5ae278 to
beeb576
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2152
When auditing an entity, Spring Data can return a new instance with its audit fields set. The Couchbase callback ignored that returned instance.
This does not affect normal mutable classes because their fields are updateddirectly. For records and classes with final fields, however, the audit dates were not saved.
Use
AuditingEntityCallbackas the single auditing mechanism. It keeps the audited replacement instance and avoids running auditing twice for mutable entities. This follows the original implementation discussion: #1102 (comment)