You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
You submit test cases (unit or integration tests) that back your changes.
You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).
For 4.0, we've introduced PredicateSpecification for improved composition, therefore, we don't want to include another nestable specification. The Join-specification seems rather specific and given the improved flexibility with From, we do not want to introduce another specification variant.
For 4.0, we've introduced PredicateSpecification for improved composition, therefore, we don't want to include another nestable specification. The Join-specification seems rather specific and given the improved flexibility with From, we do not want to introduce another specification variant.
Hi, I have found that in PredicateSpecification there is still using Root, is there any plan or solution to use From for join purpose ?
Good point @Farley-Chen. We've revised PredicateSpecification by apply <T> to From<?, T> for improved composition. While we lose a bit of type information, we also drop our opinion on type restrictions and open up the model for improved composition and reuse across e.g. Joins.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
status: declinedA suggestion or change that we don't feel we should currently apply
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposal for GH-2761