Skip to content

Issue/2761 specifications with from#3919

Closed
svenmeier wants to merge 1 commit into
spring-projects:3.5.xfrom
svenmeier:issue/2761
Closed

Issue/2761 specifications with from#3919
svenmeier wants to merge 1 commit into
spring-projects:3.5.xfrom
svenmeier:issue/2761

Conversation

@svenmeier

@svenmeier svenmeier commented Jun 13, 2025

Copy link
Copy Markdown

Proposal for GH-2761

  • You have read the Spring Data contribution guidelines.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jun 13, 2025
@svenmeier svenmeier changed the base branch from main to 3.5.x June 13, 2025 20:19
@mp911de mp911de self-assigned this Jun 16, 2025
@mp911de mp911de added status: declined A suggestion or change that we don't feel we should currently apply and removed status: waiting-for-triage An issue we've not yet triaged labels Jul 1, 2025
@mp911de

mp911de commented Jul 1, 2025

Copy link
Copy Markdown
Member

For 4.0, we've introduced PredicateSpecification for improved composition, therefore, we don't want to include another nestable specification. The Join-specification seems rather specific and given the improved flexibility with From, we do not want to introduce another specification variant.

@mp911de mp911de closed this Jul 1, 2025
@Farley-Chen

Copy link
Copy Markdown

For 4.0, we've introduced PredicateSpecification for improved composition, therefore, we don't want to include another nestable specification. The Join-specification seems rather specific and given the improved flexibility with From, we do not want to introduce another specification variant.

Hi, I have found that in PredicateSpecification there is still using Root, is there any plan or solution to use From for join purpose ?

@mp911de

mp911de commented Oct 7, 2025

Copy link
Copy Markdown
Member

Good point @Farley-Chen. We've revised PredicateSpecification by apply <T> to From<?, T> for improved composition. While we lose a bit of type information, we also drop our opinion on type restrictions and open up the model for improved composition and reuse across e.g. Joins.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: declined A suggestion or change that we don't feel we should currently apply

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants