Fix parsing of single-character string literals in JPQL and EQL collection member expressions.#4282
Open
jewoodev wants to merge 1 commit into
Conversation
…ction member expressions. Signed-off-by: jewoodev <jewoos15@naver.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JPQL and EQL currently tokenize a single-character quoted string such as
'c'asCHARACTER, while other quoted strings are tokenized asSTRINGLITERAL. Theliteralparser rule acceptedSTRINGLITERALbut notCHARACTER, causing a single-character string literal to fail when used as the left operand ofMEMBER OF.This change adds
CHARACTERto the JPQL and EQLliteralrules and covers the collection-member case with a shared query renderer round-trip test.Jakarta Persistence allows a
literalas the left operand ofMEMBER OF, defines string literals as single-quoted strings without distinguishing single-character strings from longer strings, and itself uses'Joe' MEMBER OF p.nicknamesas an example.Closes #4278