validate samesite attribute in ResponseCookie#36905
Open
dxbjavid wants to merge 1 commit into
Open
Conversation
Signed-off-by: dxbjavid <dxbjavid@gmail.com>
spring-projects-issues
added
the
status: waiting-for-triage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ResponseCookie validates the cookie name, value, domain and path but the SameSite attribute is appended to the Set-Cookie value as-is, so a value carrying control characters or a semicolon (for instance one taken from an upstream Set-Cookie by the reactive client cookie parsers) can add further attributes or split the header. It seemed safer to check it the same way as the other attributes, so this adds a SameSite check alongside the existing ones in the constructor. Control characters, non-ASCII and ';' are rejected while the usual Strict, Lax and None values still pass.