Add test retries for tests that commonly fail#11106
Closed
cppwfs wants to merge 2 commits into
Closed
Conversation
cppwfs
commented
Jun 11, 2026
cppwfs
commented
Contributor
- Disable tests that need more review
- Do not merge.
cppwfs
force-pushed
the
SI-stabilize-6.5.x-test
branch
from
bb748af to
63c1725
Compare
artembilan
requested changes
Jun 11, 2026
| public void prepResource() throws IOException { | ||
| when(inputDirectoryMock.toPath()).thenReturn(Path.of("[dir]")); | ||
| when(inputDirectoryMock.getCanonicalFile()).thenReturn(inputDirectoryMock); | ||
| when(inputDirectoryMock.getAbsoluteFile()).thenReturn(inputDirectoryMock); |
Member
There was a problem hiding this comment.
Please, don't touch file tests.
It is still failing here or there on CI.
I'll let you know when it is good to rebase.
Thanks
Contributor
Author
There was a problem hiding this comment.
Sounds good. I was about to raise this as an issue.
The PR's goal is to make sure we have stable builds.
Contributor
Author
There was a problem hiding this comment.
Plus I am going to revisit ImapMailReceiverNoDebugTests.java and clean that up in the morning.
artembilan
requested changes
Jun 11, 2026
artembilan
left a comment
artembilan
left a comment
Member
There was a problem hiding this comment.
OK. Finally the build is green.
Please, rebase to upstream 6.5.x
- Add @RetryingTest(10) annotation to tests that commonly fail. - Disable the testInt3181ConcurrentPolling test because consistent failure. Disable for now and research. - Extract IMAP retryable tests into the ImapMailReceiverNoDebugTests because of debug log setup race condition
- Remove unused code from ImapMailReceiverNoDebugTests
cppwfs
force-pushed
the
SI-stabilize-6.5.x-test
branch
from
63c1725 to
188db9c
Compare
Contributor
Author
|
Closing this "Do Not Merge" PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.