fix: preserve datetime fold in FakeDatetime conversions#601
Open
l46983284-cpu wants to merge 1 commit into
Open
fix: preserve datetime fold in FakeDatetime conversions#601l46983284-cpu wants to merge 1 commit into
l46983284-cpu wants to merge 1 commit into
Conversation
datetime_to_fakedatetime dropped the fold flag, so DST fall-back hours converted via FakeDatetime.astimezone lost EST vs EDT (issue spulec#596). Signed-off-by: Alex Chen <l46983284@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
datetime_to_fakedatetimedropped thefoldflag, so DST fall-back conversions throughFakeDatetime.astimezonecollapsed the second 01:00 (EST) into EDT underfreeze_time(issue #596).Pass
foldthrough when constructingFakeDatetime.Test plan
pytest tests/test_dst_fold_astimezone.pyPASS on 3.14.4 after patchFixes #596