[feat]: introduce runtime configuration SPI - #354
Merged
Conversation
jamieQ
marked this pull request as ready for review
June 24, 2025 18:48
jamieQ
force-pushed
the
jquadri/runtime-config
branch
from
July 22, 2025 16:04
51d2c6f to
6d6ea48
Compare
jamieQ
force-pushed
the
jquadri/runtime-config
branch
from
July 22, 2025 16:07
6d6ea48 to
c6fdcd8
Compare
kyleve
reviewed
Jul 22, 2025
| /// System for managing configuration options for Workflow runtime behaviors. | ||
| /// - important: These interfaces are subject to breaking changes without corresponding semantic | ||
| /// versioning changes. | ||
| @_spi(RuntimeConfig) |
Contributor
There was a problem hiding this comment.
Might just be a market pattern, but we always tend to prefix these (eg, WorkflowRuntimeConfig) to make it easier to grep for usages w/o potentially hitting same-name conflicts from other frameworks; but probably fine either way.
amorde
approved these changes
Jul 23, 2025
watt
approved these changes
Jul 23, 2025
| /// | ||
| /// - Parameter configuration: The runtime configuration to use. | ||
| @MainActor | ||
| public static func bootstrap( |
Contributor
There was a problem hiding this comment.
not at all a blocker, but IMO the one-time bootstrapping requirement is overkill vs having a static var that can be changed at any time
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
introduces the notion of a 'runtime configuration' in order to support opting into new behaviors to the Workflow runtime over time. currently this is behind an SPI, and should be considered experimental and exempt from semantic versioning standards.