Gate Perception suppression to debug - #390
Merged
Merged
Conversation
Co-authored-by: Codex <codex@openai.com>
johnnewman-square
force-pushed
the
johnnewman/task/debug-check
branch
from
April 15, 2026 17:15
2f21af4 to
9650e23
Compare
johnnewman-square
marked this pull request as ready for review
April 15, 2026 17:30
robmaceachern
approved these changes
Apr 21, 2026
7 tasks
johnnewman-square
added a commit
that referenced
this pull request
Jul 16, 2026
PRs #389 and #390 automatically suppressed Perception runtime warnings on platforms using native Observation. This restores the warnings by default while preserving an opt-in suppression path. ## Summary - Add `Runtime.Configuration.suppressPerceptionCheckingWhenUsingObservation`, defaulting to `false` - Continue normal Store access unless suppression is explicitly enabled - Apply suppression only in debug builds on iOS 17+, macOS 14+, tvOS 17+, and watchOS 10+ - Cover both direct state reads and child Store wrapper access - Add tests for the default warning behavior and opt-in suppression ## Test plan - [x] Run `StoreTests` on iOS 17.5 — 25 passed - [x] Run `StoreTests` on iOS 16.2 — passed with 8 expected skips - [x] Run the ObservableComposition sample app on iOS 17 to ensure the warnings are occurring by default. ## Checklist - [x] Unit Tests - [x] UI Tests (not applicable) - [x] Snapshot Tests (not applicable) - [x] I have made corresponding changes to the documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR builds on the changes from #389.
Summary
skipPerceptionCheckingbehind#if DEBUGvia a shared helperreadStateand child-wrapperaccess(...)test_nativeOptionalChildStoreObservationso native observation covers the wrapper path throughStore.access(...)Samples/Tuist/Package.resolvedWhy
Perception only consults
skipPerceptionCheckingfrom its debug-only checking path, so release builds do not need the TaskLocal wrapper. The new native optional-wrapper test closes the coverage gap in the path that motivated the original suppression.Test plan
ObservableCompositionapp.