Fix incorrect thread with main_thread property #163
Open
SilicDev wants to merge 1 commit into
Open
Conversation
Collaborator
|
can you try this branch and see if the issue persists https://github.com/srounet/Pymem/tree/enum_process_thread_realloc |
Author
|
This indeed seems to fix the issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the issue that main_thread would return an incorrect thread object
Inherently the issue is that the generator
enum_process_threadacts in place so whensortedtries to create the array to sort, the generator returns the same reference pointer, with changed values after every call, resulting inncopies of the last entry in the thread32 list. This is not even guaranteed to be a thread to be owned by the source process, hence why thequery_tebof theThreadEntry32fails as the targeted memory is not owned by the source process. Can confirm with this fix I can obtain theSMALL_TEBas seen https://github.com/SilicDev/Archipelago/blob/yohane-deepblue/worlds/yohane_deepblue/client.py#L253This fix might not be ideal, but it fixes the issue blocking the teb feature.