fix emoji selection using the touchscreen in WhatsApp - #1179
Merged
Conversation
sspanak
force-pushed
the
fix-whatsapp-emojis-3
branch
from
August 1, 2026 13:38
dbcc570 to
d31c37c
Compare
Closed
sspanak
marked this pull request as ready for review
August 1, 2026 13:38
Contributor
There was a problem hiding this comment.
🟢 Ready to approve
The change is small, localized, and consistent with existing WhatsApp-specific composing-text handling already present in AppHacks.
This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.
Pull request overview
This PR adjusts composing-text handling when committing emoji suggestions so WhatsApp reliably accepts the selected emoji when chosen via touchscreen.
Changes:
- Refreshes (forces) the composing text to the current suggestion before finishing/committing in specific app + content conditions.
- Adds a dedicated
AppHackspredicate to centralize the “needs refresh before commit” decision (currently WhatsApp + graphic-only text).
File summaries
| File | Description |
|---|---|
| app/src/main/java/io/github/sspanak/tt9/ime/helpers/SuggestionOps.java | Forces composing text refresh (via replaceComposingText) before commit/finish when AppHacks indicates it’s needed. |
| app/src/main/java/io/github/sspanak/tt9/hacks/AppHacks.java | Adds shouldRefreshComposingTextBeforeCommit(...) to detect the WhatsApp + graphic-text case that needs special handling. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.