Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Filipino language support to TT9 by introducing a new language definition, wiring up status icons for the notification/IME modes, and updating store listing metadata to include the new supported language.
Changes:
- Add
Filipino.ymllanguage definition (fil-PH) backed byfil-utf8.csv. - Add new
ic_lang_ph_{up,lo,cp}vector drawables and register them inStatusIcon’s generated icon cache. - Update icon generation script and Fastlane full descriptions to include Filipino in the supported languages list.
Reviewed changes
Copilot reviewed 9 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| scripts/iconz/generate-all.sh | Adds icon generation entry for the new ph icon set. |
| fastlane/metadata/android/en-US/full_description.txt | Updates English Play Store description supported-languages list. |
| fastlane/metadata/android/bg-BG/full_description.txt | Updates Bulgarian Play Store description supported-languages list. |
| docs/dictionaries/filWordlistReadme.txt | Documents Filipino/Tagalog wordlist sources and licenses. |
| app/src/main/res/drawable/ic_lang_ph_up.xml | Adds Filipino/PH status icon (upper-case variant). |
| app/src/main/res/drawable/ic_lang_ph_lo.xml | Adds Filipino/PH status icon (lower-case variant). |
| app/src/main/res/drawable/ic_lang_ph_cp.xml | Adds Filipino/PH status icon (capitalize variant). |
| app/src/main/java/io/github/sspanak/tt9/ui/StatusIcon.java | Registers the new ic_lang_ph_* drawables in the generated cache. |
| app/languages/definitions/Filipino.yml | Defines the Filipino language (locale, dictionary, icons, keypad layout). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.