Add datacube variables support as MLM input and output dimensions - #94
Merged
Conversation
Collaborator
Author
|
@huard @Nazim-crim FYI Initial MLM definition using datacube variables for describing a climate/ML model. |
rbavery
requested changes
Jul 9, 2025
Collaborator
Is the reverse allowed, specifying |
…delOutput', as per the JSON schema
…ds/variables in 'mlm:output'
…criptions about their implications
…m into data-cube-variables
fmigneault
marked this pull request as ready for review
July 10, 2025 03:48
Collaborator
Author
|
@rbavery All comments should be addressed. Let me know if there is something else to adjust. |
10 tasks
rbavery
previously approved these changes
Jul 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
variablesproperties to Model Input Object to allow specifying the relevant data variables used by the model, with cross-references to the datacube extension (relates to #90).bandsandvariablesproperties to Model Output Object to allow specifying the relevant bands or variables produced by the model if any applies.downscalingto Tasks as common operation for climate variable models.bandsandvariablesreferences within bothmlm:inputandmlm:output. If either location detects that eitherbandsorvariablesis provided, their corresponding sets of extensions providing relevant descriptions are verified.mlm:outputproperty to employ aModelOutputobject definition rather than directly provided properties nested under the array.bandsundermlm:inputif thevariablesproperty is provided.encoding="utf-8"parameters inopencalls leading to failing parsing of example JSON STAC Item when they contain non-ASCII characters.PYTHON_PATHinMakefilefor Windows OS.Related Issue
Type of Change
Checklist
CONTRIBUTING.mdguide;make check;Googleformat for all the methods and classes that I used.