Skip to content

lint: add dedication role test#956

Merged
acabal merged 3 commits intomasterfrom
lint-marc-dedication
Apr 10, 2026
Merged

lint: add dedication role test#956
acabal merged 3 commits intomasterfrom
lint-marc-dedication

Conversation

@robinwhittleton
Copy link
Copy Markdown
Member

This adds a check for the dto role when a dedication semantic is found. It copies the existing format (e.g. m-031).

I also removed a mistakenly listed unused rule I found in the process.

@acabal
Copy link
Copy Markdown
Member

acabal commented Apr 8, 2026

Thanks! I see you added some files to some unrelated tests, what is that?

Can you also add a test for this?

@robinwhittleton
Copy link
Copy Markdown
Member Author

There were a couple of tests that had dedication files already that started failing based on missing dto roles; I copied in the jane-austen_test-novel content.opf with an added dto role. I assume that’s the expected approach?

I’ve added a m-090 test but it passes every time with no error, and I can’t work out why. I’ll continue to poke at it.

@robinwhittleton
Copy link
Copy Markdown
Member Author

Worked it out: .DS_Store files had infected the test structure, causing the linter to silently fail early 🤦‍♂️

@acabal acabal merged commit df58f09 into master Apr 10, 2026
2 checks passed
@acabal
Copy link
Copy Markdown
Member

acabal commented Apr 10, 2026

Great, thanks!

@robinwhittleton robinwhittleton deleted the lint-marc-dedication branch April 10, 2026 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants