[6.x] Fix creating passkeys with JSON session serialization#14448
Merged
jasonvarga merged 3 commits into6.xfrom Apr 7, 2026
Merged
[6.x] Fix creating passkeys with JSON session serialization#14448jasonvarga merged 3 commits into6.xfrom
jasonvarga merged 3 commits into6.xfrom
Conversation
duncanmcclean
changed the title
duncanmcclean
changed the title
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue when creating passkeys alongside the
jsonserializer for sessions, which was made the default in Laravel 13.The WebAuthn challenge is generated using
random_bytes(), which produces binary data. Sincejson_encode()cannot encode binary data (it returnsfalsefor invalid UTF-8), the session write fails silently, resulting in an empty session file and the user being logged out.This PR fixes it by base64 encoding the challenge before storing it in the session, ensuring compatibility with both PHP and JSON session serialization methods.