[6.x] Require 2FA/passkey verification after password reset#14449
Closed
jasonvarga wants to merge 3 commits into6.xfrom
Closed
[6.x] Require 2FA/passkey verification after password reset#14449jasonvarga wants to merge 3 commits into6.xfrom
jasonvarga wants to merge 3 commits into6.xfrom
Conversation
Previously, the password reset flow would auto-login the user without requiring a 2FA code, allowing the second factor to be bypassed entirely. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
When allow_password_login_with_passkey is false and the user has passkeys, the password reset flow should not auto-login the user, matching the enforcement applied during normal login. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
3 tasks
Member
Author
|
Opted for a simpler solution in #14454 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
allow_password_login_with_passkeyisfalseand the user has passkeys. Instead, redirect to the login page.ResetPasswordTestcovering all scenarios with a data provider for CP/web.Test plan
ResetPasswordTestcovers: