Skip to content

fix: accept port 0 in parseCmdArg #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nitely merged 1 commit into from
May 21, 2026
Merged

fix: accept port 0 in parseCmdArg #146

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions confutils/std/net.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,13 +23,13 @@ func completeCmdArg*(T: type IpAddress, val: string): seq[string] =
func parseCmdArg*(T: type Port, s: string): T {.gcsafe, raises: [ValueError].} =
template fail =
raise newException(ValueError,
"The supplied port must be an integer value in the range 1-65535")
"The supplied port must be an integer value in the range 0-65535")

var intVal: int
let parsedChars = try: parseInt(s, intVal)
except CatchableError: fail()

if parsedChars != len(s) or intVal < 1 or intVal > 65535:
if parsedChars != len(s) or intVal < 0 or intVal > 65535:
fail()

return Port(intVal)
Expand Down
Loading