fix(login): improve login by calling ens asyncly and upping status-go#20144
Open
jrainville wants to merge 1 commit intomasterfrom
Open
fix(login): improve login by calling ens asyncly and upping status-go#20144jrainville wants to merge 1 commit intomasterfrom
jrainville wants to merge 1 commit intomasterfrom
Conversation
jrainville
requested review from
alexjba,
caybro,
micieslak and
noeliaSD
as code owners
This was referenced Mar 2, 2026
Member
Jenkins BuildsClick to see older builds (43)
|
caybro
approved these changes
Mar 3, 2026
jrainville
force-pushed
the
fix/slow-login-with-bad-connection
branch
from
0533ea0 to
75dd8e8
Compare
Fixes #19856 There were three issues: 1. The currency service in status-go did multiple network checks. Now in go routines 2. The timesource service did a network call, also in go routines now 3. We did a call to the ENS contract to get the registered address and that took a lot of time too. I made it async in the code. With all these changes, the app load is at least 10 times faster with a shitty internet.
jrainville
force-pushed
the
fix/slow-login-with-bad-connection
branch
from
75dd8e8 to
d7db7ee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does the PR do
Fixes #19856
There were three issues:
With all these changes, the app load is at least 10 times faster with a shitty internet.
Affected areas
Quality checklist
My PR is consistent with this document: QML Architecture Guidelines
Screencapture of the functionality
I did these tests by lowering my internet download speed to 1024Kbps with a 400ms latency.
Before:
long-login.webm
After:
fast-login2.webm
As you can see, it used to take 50 seconds, now it takes 10.
Impact on end user
Greatly improves login speed when having very bad internet connection
How to test
Risk
Medium
Since I make some of the calls async, especially in the backend, some things might be called out of order, but I haven,t had any catastrophic errors so far