refactor: remove status-keycard-go submodule and update references to reference to status-keycard-qt library#20198
Open
saledjenic wants to merge 1 commit intomasterfrom
Open
refactor: remove status-keycard-go submodule and update references to reference to status-keycard-qt library#20198saledjenic wants to merge 1 commit intomasterfrom
saledjenic wants to merge 1 commit intomasterfrom
Conversation
Member
Jenkins BuildsClick to see older builds (33)
|
… reference to status-keycard-qt library - Deleted the status-keycard-go submodule from .gitmodules and Makefile. - Updated config.nims to reference KEYCARD_LIBDIR instead of STATUSKEYCARDGO_LIBDIR. - Adjusted build scripts and feature flags to remove dependencies on status-keycard-go. - The code aligned.
saledjenic
force-pushed
the
chore/keycard-lib-alingment
branch
from
d9595ce to
9df6e17
Compare
caybro
approved these changes
Mar 16, 2026
alexjba
approved these changes
Mar 16, 2026
siddarthkay
reviewed
Mar 16, 2026
| rcedit $(OUTPUT)/bin/Status.exe --set-icon $(OUTPUT)/resources/status.ico | ||
| rcedit $(OUTPUT)/Status.exe --set-icon $(OUTPUT)/resources/status.ico | ||
| cp $(DOTHERSIDE_LIBFILE) $(STATUSGO) $(STATUSKEYCARDGO) $(NIMSDS_LIBFILE) $(STATUSQ_LIB_PATH)/* $(STATUSQ_BUILD_PATH)/bin/$(COMMON_CMAKE_BUILD_TYPE)/* $(OUTPUT)/bin/ | ||
| cp $(DOTHERSIDE_LIBFILE) $(STATUSGO) $(KEYCARD_LIB) $(NIMSDS_LIBFILE) $(STATUSQ_LIB_PATH)/* $(STATUSQ_BUILD_PATH)/bin/$(COMMON_CMAKE_BUILD_TYPE)/* $(OUTPUT)/bin/ |
Contributor
There was a problem hiding this comment.
won't this work here? $(STATUSKEYCARD_QT_LIB) if it does we can probably get rid of
KEYCARD_LIB := $(STATUSKEYCARD_QT_LIB)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #20290