Merged
Conversation
alaibe
requested review from
a team,
alexjba,
caybro,
micieslak and
noeliaSD
as code owners
saledjenic
approved these changes
Mar 26, 2026
Member
Jenkins BuildsClick to see older builds (58)
|
caybro
reviewed
Mar 26, 2026
Member
There was a problem hiding this comment.
The QML ui tests are failing massively, e.g.:
14:28:45 1: FAIL! : QmlTests::SwapModal::test_modal_pay_input_switching_accounts() property visible
14:28:45 1: Actual (): false
14:28:45 1: Expected (): true
14:28:45 1: Loc: [/home/jenkins/workspace/s_linux_x86_64_tests-ui_PR-20272/storybook/qmlTests/tests/tst_SwapModal.qml(1413)]
or
14:28:53 1: FAIL! : QmlTests::SwapModal::test_network_default_and_selection() Compared values are not the same
14:28:53 1: Actual (): 560048
14:28:53 1: Expected (): 11155111
14:28:53 1: Loc: [/home/jenkins/workspace/s_linux_x86_64_tests-ui_PR-20272/storybook/qmlTests/tests/tst_SwapModal.qml(408)]
8487e5f to
8da8d36
Compare
friofry
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add Hoodi chain
status-im/status-go#7384