feat(keycard): wireframe for the new keycard setting module#20337
Merged
saledjenic merged 7 commits intomasterfrom Apr 6, 2026
Merged
feat(keycard): wireframe for the new keycard setting module#20337saledjenic merged 7 commits intomasterfrom
saledjenic merged 7 commits intomasterfrom
Conversation
Member
Jenkins BuildsClick to see older builds (35)
|
alaibe
approved these changes
Apr 3, 2026
saledjenic
force-pushed
the
keycard/new-keycard-settings
branch
3 times, most recently
from
4beff91 to
66301f8
Compare
…re migrated to keycard There is already a keycard next to the key pair name, pointing that the key pair is "on keycard", no need to have the keycard icon, it should be aligned with the key pair origin. Another point the cold wallet being use does not matter until we know the key pair is the right one. A point is to define how hardware interfaces and in app key pair names work together, since the same key pair can exist on Ledger, Keycard, or an air-gapped wallet like Keystone.
…ace where the component is used Avoid assumptions about parent and places where this component is going to be used, but instead provide component index (`compIndex`) explicitly.
This change is brings a new keycard management module which will be used mainly for settings keycard flows.
This commit adds a new keycard settings module that reads the keycard and prepares available actions based on the keycard state. Individual keycard actions are not part of these changes. Note: a new keycard settings part should be uncommented in `SettingsEntriesModel.qml` once it's fully ready for integration.
saledjenic
force-pushed
the
keycard/new-keycard-settings
branch
from
66301f8 to
b3ecdda
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains several commits (each commit is a single logical change) with the goal of preparing the code for adding a new keycard settings module that reads the keycard and prepares available actions based on the keycard state.
Individual keycard actions are not part of these changes.
Note: a new keycard settings part should be uncommented in
SettingsEntriesModel.qmlonce it's fully ready for integration.This work can be merged without affecting anything in the master branch.
Closes: #20301