Ignore window if it's just the tab manager in one tab#174
Ignore window if it's just the tab manager in one tab#174cormacrelf wants to merge 1 commit intostefanXO:masterfrom
Conversation
| count + " " + noun + (count !== 1 ? suffix : ''));}; | ||
|
|
||
| /** If a window only contains our extension as a popup in a single tab, we | ||
| * don't want it polluting its own tab manager, where it will always be |
There was a problem hiding this comment.
The spacing here seems to be off. Also, probably no need for the second astrisk when you start the comment block. :)
|
Assuming this works, it seems like a nice improvement. Is it convenient to also ignore windows with only empty tabs? I think it might actually be a good idea to ignore empty tabs even in windows that won't be ignored, but that's probably a different feature for a different PR. Just some ideas. |
|
First of all - thank you for helping by submitting a PR. I'm a bit concerned about the functionality though - how do I get back to the window that has the tab manager ( e.g. from a popup ) 🤔 Maybe we should simply move this window to the end of the list, instead of hiding it? Or create a separate section like "Minimized windows" - called "Other". But then we'll lose simplicity. |
|
Oh, is there a way to check the identity of the current tab and compare it? That would allow hiding it from only the one through which it is viewed. |
|
Basically this is all an A/B problem where what I actually want is a floating window that doesn't get hidden from view when other windows are activated. (Especially since clicking anywhere in a single-tab-window tab manager switches to another window.) I don't think you can do that though, hence this. |
We know if we're in a popup, or own window by checking If we're in own window, we can check And then we can work from there 🤔 Did you mean that? |
3 participants
No description provided.