Skip to content

Use correct name for Path property #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stefanak-michal merged 1 commit into from
Jan 21, 2026
Merged

Use correct name for Path property #183

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 19 additions & 5 deletions src/protocol/v1/structures/Path.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,16 +16,30 @@
class Path implements IStructure
{
/**
* @param Node[] $nodes
* @param UnboundRelationship[] $rels list of unbound relationships
* @param int[] $ids relationship id and node id to represent the path
* List of integers describing how to construct the path from nodes and rels
* @var int[]
*/
public readonly array $indices;

/**
* @deprecated use $indices instead. For some reason originally I named it ids, but the correct name is indices.
* @var int[]
*/
public readonly array $ids;

/**
* @param Node[] $nodes List of nodes
* @param UnboundRelationship[] $rels List of unbound relationships
* @param int[] $indices Relationship id and node id to represent the path
*/
public function __construct(
public readonly array $nodes,
public readonly array $rels,
public readonly array $ids
array $indices
)
{
$this->ids = $indices;
$this->indices = $indices;
}

public function __toString(): string
Expand All @@ -34,7 +48,7 @@ public function __toString(): string
'start' => json_decode(reset($this->nodes), true),
'end' => json_decode(end($this->nodes), true),
'segments' => [],
'length' => count($this->ids) - 1
'length' => count($this->indices) - 1
];

for ($i = 0; $i < count($this->nodes) - 1; $i++) {
Expand Down