feat: optimize build - #569
Conversation
stellar-cli v27 includes `--optimize` by default. We just need to include `additional-libs` in order to enable it. This makes the build for `stellar-scaffold-cli` much bigger! Alternatives ------------ Rather than embedding `stellar-cli`, we could shell out to it. This would require a more significant re-architecture. Is it worth it, before shipping this feature? (Ideally, we should do some more data-driven comparison of the current approach vs status quo to understand the increased build/install time of `stellar-scaffold-cli` to see if we think it's worth going with the simpler-to-ship approach for now.)
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
willemneal
left a comment
There was a problem hiding this comment.
Makes sense to me and we can shell out later if there are issues and in general move away from reimplementing the stellar cli
## 🤖 New release * `stellar-scaffold-cli`: 0.0.25 -> 0.0.26 (✓ API compatible changes) * `stellar-scaffold-reporter`: 0.1.1 -> 0.1.2 (✓ API compatible changes) <details><summary><i><b>Changelog</b></i></summary><p> ## `stellar-scaffold-cli` <blockquote> ## [0.0.26](stellar-scaffold-cli-v0.0.25...stellar-scaffold-cli-v0.0.26) - 2026-07-21 ### Added - allow --no-template option on init ([#564](#564)) - optimize build ([#569](#569)) </blockquote> ## `stellar-scaffold-reporter` <blockquote> ## [0.1.2](stellar-scaffold-reporter-v0.1.1...stellar-scaffold-reporter-v0.1.2) - 2026-07-21 ### Other - *(stellar-scaffold-reporter)* rm dupe changelog ([#563](#563)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/release-plz/release-plz/). --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Willem Wyndham <willem@ahalabs.dev> Co-authored-by: Chad Ostrowski <221614+chadoh@users.noreply.github.com> Co-authored-by: Willem Wyndham <willem@wyndham.tech> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
stellar-cli v27 includes
--optimizeby default.We just need to include
additional-libsin order to enable it.This makes the build for
stellar-scaffold-climuch bigger!Alternatives
Rather than embedding
stellar-cli, we could shell out to it. This would require a more significant re-architecture. Is it worth it, before shipping this feature? (Ideally, we should do some more data-driven comparison of the current approach vs status quo to understand the increased build/install time ofstellar-scaffold-clito see if wethink it's worth going with the simpler-to-ship approach for now.)