Skip to content

feat: optimize build - #569

Merged
chadoh merged 1 commit into
mainfrom
feat/optimize
Jul 21, 2026
Merged

feat: optimize build#569
chadoh merged 1 commit into
mainfrom
feat/optimize

Conversation

@chadoh

@chadoh chadoh commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

stellar-cli v27 includes --optimize by default.

We just need to include additional-libs in order to enable it.

This makes the build for stellar-scaffold-cli much bigger!

Alternatives

Rather than embedding stellar-cli, we could shell out to it. This would require a more significant re-architecture. Is it worth it, before shipping this feature? (Ideally, we should do some more data-driven comparison of the current approach vs status quo to understand the increased build/install time of stellar-scaffold-cli to see if we
think it's worth going with the simpler-to-ship approach for now.)

stellar-cli v27 includes `--optimize` by default.

We just need to include `additional-libs` in order to enable it.

This makes the build for `stellar-scaffold-cli` much bigger!

Alternatives
------------

Rather than embedding `stellar-cli`, we could shell out to it. This
would require a more significant re-architecture. Is it worth it, before
shipping this feature? (Ideally, we should do some more data-driven
comparison of the current approach vs status quo to understand the
increased build/install time of `stellar-scaffold-cli` to see if we
think it's worth going with the simpler-to-ship approach for now.)
@socket-security

Copy link
Copy Markdown

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action Severity Alert  (click "▶" to expand/collapse)
Warn High
Obfuscated code: cargo openssl is 90.0% likely obfuscated

Confidence: 0.90

Location: Package overview

From: ?cargo/reqwest@0.12.24cargo/openssl@0.10.81

ℹ Read more on: This package | This alert | What is obfuscated code?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Packages should not obfuscate their code. Consider not using packages with obfuscated code.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore cargo/openssl@0.10.81. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

@chadoh
chadoh requested a review from willemneal July 21, 2026 16:11

@willemneal willemneal left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me and we can shell out later if there are issues and in general move away from reimplementing the stellar cli

@chadoh
chadoh merged commit 17914b7 into main Jul 21, 2026
9 checks passed
@chadoh
chadoh deleted the feat/optimize branch July 21, 2026 16:43
@github-actions github-actions Bot mentioned this pull request Jul 21, 2026
chadoh added a commit that referenced this pull request Jul 23, 2026
## 🤖 New release

* `stellar-scaffold-cli`: 0.0.25 -> 0.0.26 (✓ API compatible changes)
* `stellar-scaffold-reporter`: 0.1.1 -> 0.1.2 (✓ API compatible changes)

<details><summary><i><b>Changelog</b></i></summary><p>

## `stellar-scaffold-cli`

<blockquote>

##
[0.0.26](stellar-scaffold-cli-v0.0.25...stellar-scaffold-cli-v0.0.26)
- 2026-07-21

### Added

- allow --no-template option on init
([#564](#564))
- optimize build
([#569](#569))
</blockquote>

## `stellar-scaffold-reporter`

<blockquote>

##
[0.1.2](stellar-scaffold-reporter-v0.1.1...stellar-scaffold-reporter-v0.1.2)
- 2026-07-21

### Other

- *(stellar-scaffold-reporter)* rm dupe changelog
([#563](#563))
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/release-plz/release-plz/).

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Willem Wyndham <willem@ahalabs.dev>
Co-authored-by: Chad Ostrowski <221614+chadoh@users.noreply.github.com>
Co-authored-by: Willem Wyndham <willem@wyndham.tech>
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants