Fix InstantiateWasmImports which was broken by protocol-version gating#1429
Open
graydon wants to merge 2 commits into
Open
Fix InstantiateWasmImports which was broken by protocol-version gating#1429graydon wants to merge 2 commits into
graydon wants to merge 2 commits into
Conversation
tomerweller
approved these changes
Jul 13, 2024
leighmcculloch
approved these changes
Jul 15, 2024
leighmcculloch
enabled auto-merge
July 15, 2024 00:11
jayz22
approved these changes
Jul 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The support for (and p21 use of) protocol gating on host functions breaks the benchmark code that imports all functions into a p20 contract. This fixes the bug.