add socket tier 1 reachability analysis#1697
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a dedicated GitHub Actions workflow to run Socket’s full-application reachability scan for rs-soroban-env, with scheduled weekly execution and manual workflow_dispatch support, and with job-level signaling for Tier 2 fallback conditions.
Changes:
- Introduces a new
socket-scan.ymlworkflow that installs Rust + Node and runssocket scan create --reach. - Captures scan output to detect Tier 2 reachability fallbacks and emits a GitHub Actions
::warning::without failing the job. - Documents expected “green/yellow/red” semantics and known upstream analyzer limitations directly in the workflow file.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| run: corepack enable | ||
|
|
||
| - name: Install Socket CLI | ||
| run: npm install -g socket |
There was a problem hiding this comment.
Pinning seems like a good idea.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0b147af316
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| socket scan create --reach \ | ||
| --org=stellar \ |
There was a problem hiding this comment.
On scheduled/manual runs this invocation does not pass --repo/--branch, and there is no repo-local Socket config to supply them. Socket's scan create help defaults those fields to socket-default-repository/socket-default-branch, so the weekly reachability results will be filed under the generic defaults instead of rs-soroban-env and will not update the intended repository history/alerts page; add explicit repo/branch metadata (and mark the default branch as needed).
Useful? React with 👍 / 👎.
More info: https://stellarorg.atlassian.net/wiki/spaces/SCRT/pages/5689311233/Socket+Tier+1+Reachability+Analysis