fix(host): bound ed25519-dalek below v3#1706
Draft
kalepail wants to merge 2 commits into
Draft
Conversation
Host test utilities use rand_core 0.6 through rand_chacha 0.3. Fresh lockfiles otherwise select ed25519-dalek 3 and fail the CryptoRng bound. Fixes stellar#1705
kalepail
force-pushed
the
fix/ed25519-dalek-v2-1705
branch
from
July 15, 2026 14:14
9b8fea7 to
960ebd0
Compare
leighmcculloch
approved these changes
Jul 20, 2026
leighmcculloch
left a comment
leighmcculloch
left a comment
Member
There was a problem hiding this comment.
This looks good although we should simplify it per below.
| hmac = "0.12.1" | ||
| # NB: We'll need to pin this again after switching the Core to the new env version. | ||
| ed25519-dalek = {version = ">=2.0.0", features = ["rand_core"] } | ||
| ed25519-dalek = {version = ">=2.0.0, <3.0.0", features = ["rand_core"] } |
Member
There was a problem hiding this comment.
This definition simply needs to be the version, it is equivalent.
Suggested change
| ed25519-dalek = {version = ">=2.0.0, <3.0.0", features = ["rand_core"] } | |
| ed25519-dalek = {version = "2.0.0", features = ["rand_core"] } |
When no operator is provided, then it is equivalent to using a caret ^2.0.0 which is equivalent to >= 2.0.0, <3.0.0.
Ref: https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html#version-requirement-syntax
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Bound
soroban-env-host'sed25519-dalekdependency to the compatible 2.x major.Why
The host uses
rand_chacha 0.3.1/rand_core 0.6when it callsSigningKey::generatein test utilities. The existing>=2.0.0constraint lets a fresh lockfile selected25519-dalek 3.0.0/rand_core 0.10, which makessoroban-sdk 27.0.0withtestutilsfail to compile due to an unsatisfiedCryptoRngbound.This is the narrow constraint fix discussed in #1705. The adjacent manifest comments already require these RNG-related versions to match.
Validation:
ed25519-dalek 2.2.0, not 3.0.0.cargo test -p soroban-env-host --lib: 766 passed, 0 failed.Fixes #1705.
Known limitations
The published
soroban-env-host 27.0.0crate will still require a patch release (or a downstream direct pin/lockfile) for existing SDK 27 consumers to receive this bound.