Add tests for wrong-length seeds and signed payloads - #130
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds coverage for invalid Ed25519 seed lengths and zero-length signed payloads.
Changes:
- Adds private-key test vectors.
- Tests short and oversized private keys.
- Tests a minimum-sized signed payload declaring zero length.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
tests/tools/strkey-encode/main.go |
Adds private-key vectors. |
tests/tests.rs |
Adds payload-length tests. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
leighmcculloch
enabled auto-merge (squash)
August 10, 2026 07:56
dmkozh
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add tests covering two payload-length edge cases in
ed25519::PrivateKeyanded25519::SignedPayloadthat were previously unexercised.Why
A review comparing this crate's strkey validation tests against stellar/go-stellar-sdk#5977 found two gaps:
ed25519::PrivateKey::from_stringdoesn't have a test for a wrong-length seed payload, andSignedPayload::from_payloaddoes not have a test for a 40-byte payload that declares a zero-length inner payload.