Fix race condition in rebuildInMemorySorobanStateForTesting - #5351
Merged
Conversation
6 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a test-only race between Soroban state rebuilding and background module-cache compilation.
Changes:
- Completes pending compilation before resetting
ApplyState. - Restores phase transitions before rebuilding in-memory Soroban state.
graydon
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a flaky test I think I ran into on an unrelated PR. It looks like we can call the test only module cache rebuild function while a real, background module cache build is under way, causing an assert failure. This just makes sure we finish any in-progress builds before calling the test reset function.
Checklist
clang-formatv8.0.0 (viamake formator the Visual Studio extension)