Don't disable ASLR when re-running tests under LLDB, to work in CI - #5366
Merged
Conversation
graydon
force-pushed
the
disable-aslr-in-lldb-rerun
branch
from
July 24, 2026 03:09
01d942b to
0a5ad6c
Compare
graydon
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Configures LLDB reruns to preserve ASLR, avoiding CI failures caused by restricted personality(2) calls.
Changes:
- Sets
target.disable-aslrtofalsebefore loading the test executable. - Applies the fix to PostgreSQL and non-PostgreSQL test runners.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/test/run-selftest-pg |
Updates LLDB invocation for PostgreSQL tests. |
src/test/run-selftest-nopg |
Updates LLDB invocation for non-PostgreSQL tests. |
anupsdf
approved these changes
Jul 24, 2026
graydon
enabled auto-merge
July 24, 2026 05:10
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When tests fail in CI the runner tries to re-run the failing test under LLDB to get a backtrace. LLDB tries to disable ASLR on startup using personality(2) and this in turn doesn't work on most CI runners because it's a privileged operation and the container they're running in doesn't allow it, so rather than any useful backtrace diagnostics we get a failure like:
This PR modifies how we run LLDB to tell it not to try to disable ASLR, which means it won't fail, which means it should be more likely to start and produce a backtrace.