Extend overlay ed25519 signature verification budget to protocol - #5393
Merged
Conversation
This PR extends the existing overlay level ed25519 signature verification budget to the protocol level. The new cap activates at the p28 protocol boundary.
Contributor
There was a problem hiding this comment.
Pull request overview
Extends the existing overlay Ed25519 verification budget into protocol-level transaction validation starting with protocol 28.
Changes:
- Defines the p28 activation boundary.
- Enforces the 1,000-verification budget outside overlay validation.
- Generalizes budget-related naming and state.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/util/ProtocolVersion.h |
Defines the activation protocol. |
src/transactions/SignatureChecker.h |
Generalizes budget declarations. |
src/transactions/SignatureChecker.cpp |
Activates enforcement from p28. |
marta-lokhova
approved these changes
Jul 29, 2026
sisuresh
added a commit
to sisuresh/stellar-core
that referenced
this pull request
Jul 30, 2026
Conflict in src/util/ProtocolVersion.h: stellar#5393 added TX_ED25519_VERIFY_BUDGET_PROTOCOL_VERSION in the same place this branch removed the #ifdef CAP_0085_EXECUTABLE_REF. Resolution keeps both -- the new constant, and EXTERNAL_EXECUTABLE_REF_PROTOCOL_VERSION ungated. Also bumps stellar-quorum-analyzer to 502a354 (stellar#23), which repins its stellar-xdr to the same git rev as the p28 host so their XDR_FILES_SHA256 agree and checkXDRFileIdentity passes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extends the existing overlay level ed25519 signature verification budget to the protocol level. The new cap activates at the p28 protocol boundary.