Bring back the Rust XDR parsing check. - #5396
Merged
Merged
Conversation
This check has been removed in commit `4287224758c47dc6cdc0c14930754c898b886e51`, however it's still necessary for most of the Core builds that support 2 protocol version. This change reverts the removal commit and does a bit of necessary refactoring to support the new build.
Contributor
There was a problem hiding this comment.
Pull request overview
Restores protocol-aware Rust XDR validation while preserving pre-p28 depth behavior.
Changes:
- Adds protocol-specific XDR parsing and depth validation.
- Applies validation to regular and fee-bump transactions.
- Restores compatibility tests and centralizes protocol-link checks.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
src/transactions/TransactionUtils.h |
Declares XDR validation helper. |
src/transactions/TransactionUtils.cpp |
Implements protocol-aware validation. |
src/transactions/TransactionFrame.cpp |
Validates regular envelopes. |
src/transactions/FeeBumpTransactionFrame.cpp |
Validates fee-bump envelopes. |
src/transactions/test/TxEnvelopeTests.cpp |
Restores compatibility tests. |
src/transactions/test/InvokeHostFunctionTests.cpp |
Uses shared protocol-link helper. |
src/test/TestUtils.h |
Declares shared test helper. |
src/test/TestUtils.cpp |
Implements shared test helper. |
graydon
approved these changes
Jul 29, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This check has been removed in commit
4287224758c47dc6cdc0c14930754c898b886e51, however it's still necessary for most of the Core builds that support 2 protocol version.This change reverts the removal commit and does a bit of necessary refactoring to support the new build.
Checklist
clang-formatv8.0.0 (viamake formator the Visual Studio extension)