Updating fee_pool docs to accurately represent what the value is - #2330
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the data dictionary documentation to clarify that fee_pool represents a cumulative, running balance (in stroops) rather than fees collected within a specific ledger/day, improving accuracy for analytics consumers.
Changes:
- Clarify
fee_poolsemantics in the ledger-level gold table (cumulative as-of ledger close). - Clarify
fee_poolsemantics in the daily gold table (cumulative as-of last ledger close for the day; point tototal_fee_chargedfor daily fees). - Clarify
fee_poolsemantics in the bronzehistory_ledgerssource table (running balance in ledger header).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| docs/data/analytics/hubble/data-catalog/data-dictionary/gold/ledger-fee-stats-agg.mdx | Updates fee_pool column description to specify it’s a cumulative (stroops) running total as of ledger close. |
| docs/data/analytics/hubble/data-catalog/data-dictionary/gold/daily-fee-stats-agg.mdx | Updates fee_pool to reflect end-of-day cumulative balance (from last ledger) and directs readers to total_fee_charged for daily fees. |
| docs/data/analytics/hubble/data-catalog/data-dictionary/bronze/history-ledgers.mdx | Updates fee_pool description to define it as the cumulative (stroops) running balance stored in the ledger header. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
amishas157
approved these changes
Mar 27, 2026
|
Preview is available here: |
zachfedor
pushed a commit
to zachfedor/stellar-docs
that referenced
this pull request
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the fee_pool column descriptions in three Hubble data dictionary pages (history-ledgers, ledger-fee-stats-agg, daily-fee-stats-agg) to clarify that fee_pool is a cumulative running total, not a
per-ledger or per-day amount. This aligns the public docs with the model fix in stellar-dbt-public.