Sync SAC event doc-comments to CAP-67 shapes - #2704
Merged
Merged
Conversation
|
Something went wrong with PR preview build please check |
Contributor
There was a problem hiding this comment.
Pull request overview
Syncs three embedded SAC event comments with CAP-67 and the Rust SDK.
Changes:
- Adds the SEP-11 asset topic.
- Removes the obsolete clawback admin topic.
- However, #2593’s broader event-schema documentation remains incomplete.
Recommendation: NEEDS-CHANGES — fully address #2593 or leave it open.
Comment on lines
+193
to
+194
| /// Emits an event with topics `["mint", to: Address, | ||
| /// sep0011_asset: String], data = amount: i128` |
Member
Author
There was a problem hiding this comment.
Defer to @kalepail on this. I'll still link this issue and let it close, and then I'll defer to him if he wants to reopen it for that part of it. I think this PR resolves the immediate inconsistency, but we might want to do something here wrt comparison tables.
dmkozh
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Update the
set_authorized,mint, andclawbackevent doc-comments in the embeddedStellarAssetInterfacecode block on the Stellar Asset Contract page to the CAP-67 event shapes.Why
CAP-0067 removed the
admintopic from these SAC events and appended a trailing SEP-11 asset topic, but this page's embedded copy of the interface still showed the pre-CAP-67 shapes. stellar/rs-soroban-sdk#1956 fixed this in the soroban-sdk. This change syncs the docs to match the sdk.Close #2593