Tighten release tag filter in galexie workflow - #75
Merged
Conversation
The previous `galexie-v*` glob matched any string starting with the prefix, including tags containing shell metacharacters that could be re-evaluated when downstream tooling expands `RELEASE_VERSION` into a shell command. Constrain the filter to well-formed semver tags (`galexie-vX.Y.Z` and `galexie-vX.Y.Z-rcN`) so non-conforming tags never trigger a release build.
Contributor
There was a problem hiding this comment.
Pull request overview
Tightens the tag trigger filter for the Galexie release workflow so only well-formed semver tags (with optional -rcN suffix) can start a release build, preventing arbitrary suffixes (including shell metacharacters) from flowing through RELEASE_VERSION into unquoted docker tag/docker push commands.
Changes:
- Replace the broad
galexie-v*tag glob with two explicit patterns forgalexie-vX.Y.Zandgalexie-vX.Y.Z-rcN.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
leighmcculloch
approved these changes
May 28, 2026
karthikiyer56
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
galexie-v*tag glob in.github/workflows/galexie.ymlwith two explicit patterns matchinggalexie-vX.Y.Zandgalexie-vX.Y.Z-rcN.Why
The previous glob accepted arbitrary suffixes, including ones containing shell metacharacters.
RELEASE_VERSIONflows from the tag (GITHUB_REF_NAME) into$GITHUB_ENVand then throughmake docker-push-release, where it lands unquoted indocker tag/docker pushshell commands. Constraining the filter at the trigger layer prevents non-conforming tags from ever starting a release build.Test plan
galexie-v1.2.3,galexie-v10.20.30,galexie-v1.2.3-rc1,galexie-v1.2.3-rc99; rejectsgalexie-v1.2,galexie-vX.Y.Z,galexie-v1.2.3-beta,galexie-v1.2.3-rc,galexie-v1.2.3-rcX,galexie-v1.2.3.4,galexie-v\$(curl evil),galexie-v1.2.3 ; rm -rf /.act push --dryrun -W .github/workflows/galexie.ymlparses the workflow cleanly with the new filter syntax.