P27 integration - #76
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f4bec803bd
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
leighmcculloch
left a comment
leighmcculloch
left a comment
There was a problem hiding this comment.
The commits on main that are being pulled in should be separated into a separate PR that merges main into protocol-next, preserving those commits, and so I think this PR should be rebased on protocol-next and reduced to the v27 updates.
Looks good otherwise.
Bump stellar-core to 27.0.0-3288.7696c069d.noble and go-stellar-sdk to the protocol-next commit carrying CAP-0071 XDR (stellar/go-stellar-sdk#5945). go-xdr follows transitively (DecodeDefaultMaxDepth 250 -> 1500). Adapts test/integration_test.go to GetFile's widened return signature.
bfcb102 to
937fb26
Compare
3 participants
Bumps stellar-core to
27.0.0-3288.7696c069d.nobleand go-stellar-sdk to the protocol-next commit carrying CAP-0071 XDR (stellar/go-stellar-sdk#5945).Adapts test/integration_test.go to datastore.GetFile's widened return signature (added int64 size return).