Merge protocol-next back to main for release - #79
Merged
Conversation
Bump stellar-core to 27.0.0-3288.7696c069d.noble and go-stellar-sdk to the protocol-next commit carrying CAP-0071 XDR (stellar/go-stellar-sdk#5945). go-xdr follows transitively (DecodeDefaultMaxDepth 250 -> 1500). Adapts test/integration_test.go to GetFile's widened return signature.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
Merges the protocol-next line of work back into main in preparation for the Protocol 27 / stellar-core v27 release, updating dependencies and CI/test wiring to match the updated SDK/datastore APIs.
Changes:
- Bump
github.com/stellar/go-stellar-sdk(and transitivego-xdr) to pick up Protocol 27 / CAP-0071 XDR updates. - Update integration tests to match the updated
datastore.GetFilereturn signature. - Update CI workflow stellar-core package pins and add a v27.0.0 entry to the root changelog.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
test/integration_test.go |
Adjusts integration tests for updated datastore.GetFile return values. |
go.mod |
Bumps go-stellar-sdk and go-xdr versions for Protocol 27 support. |
go.sum |
Updates module checksums corresponding to dependency bumps. |
CHANGELOG.md |
Adds a v27.0.0 release section describing Protocol 27-related bumps. |
.github/workflows/galexie.yml |
Updates CI stellar-core package versions used for integration tests and image builds. |
Comments suppressed due to low confidence (1)
.github/workflows/galexie.yml:26
- The inline comments about the Quickstart image are now misleading: they claim this value is a multi-arch index SHA and reference
stellar/quickstart:future, but the workflow actually pins to the tagstellar/quickstart:pr799-future. This makes it unclear what is intended to be pinned and how to update it alongside the stellar-core version bump.
# this pins to a version of quickstart:testing that has the same version as GALEXIE_INTEGRATION_TESTS_CAPTIVE_CORE_BIN
# this is the multi-arch index sha, get it by 'docker buildx imagetools inspect stellar/quickstart:future'
GALEXIE_INTEGRATION_TESTS_QUICKSTART_IMAGE: stellar/quickstart:pr799-future
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2b17355a87
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
tamirms
approved these changes
Jun 10, 2026
…am (#72) (#81) Bumps the go_modules group with 1 update in the / directory: [github.com/aws/aws-sdk-go-v2/aws/protocol/eventstream](https://github.com/aws/aws-sdk-go-v2). Updates `github.com/aws/aws-sdk-go-v2/aws/protocol/eventstream` from 1.6.11 to 1.7.8 - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Commits](aws/aws-sdk-go-v2@service/rum/v1.6.11...service/m2/v1.7.8) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go-v2/aws/protocol/eventstream dependency-version: 1.7.8 dependency-type: indirect dependency-group: go_modules ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
otherwise).
services/friendbot, orallordocif the changes are broad or impact manypackages.
Thoroughness
.mdfiles, etc... affected by this change).
Release planning
CHANGELOG.mdwithin the component folder structure. For example, if I changed horizon, then I updated (services/horizon/CHANGELOG.md. I add a new line item describing the change and reference to this PR. If I don't update a CHANGELOG, I acknowledge this PR's change may not be mentioned in future release notes.semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
Merge protocol-next back to main for release