Point stellar-xdr at the ungated rev - #23
Merged
Merged
Conversation
stellar-core's checkXDRFileIdentity compares this crate's XDR_FILES_SHA256 against the current soroban host's. Core is bumping to protocol 28, whose host pins stellar-xdr by git rev, so the published 27.0.0 crate no longer matches: Stellar-contract.x hashes 5d8063e6 here versus b87e9474 there, and core aborts at startup. Pin the same git rev (stellar/rs-stellar-xdr#565, where CAP-0083 and CAP-0085 were ungated) so the hashes agree. This reverts to a plain version pin once rs-stellar-xdr publishes a release carrying those changes.
There was a problem hiding this comment.
Pull request overview
Pins stellar-xdr to the protocol-28-compatible revision so XDR identity hashes match stellar-core.
Changes:
- Replaces the registry dependency with the matching Git revision.
- Updates lockfile sources and transitive dependencies.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
Cargo.toml |
Pins stellar-xdr to revision 3305b3e. |
Cargo.lock |
Records the Git source and updated build dependency. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Unrelated to the xdr bump: this lint has failed on main since 2026-07-09, because it only fires on the newer clippy CI uses. Fixing it here so this PR can go green. Applies clippy's own suggestion; the loop never used the value.
jayz22
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
stellar-core's
checkXDRFileIdentitycompares this crate'sXDR_FILES_SHA256against the current soroban host's. Core is bumping to protocol 28 (stellar/stellar-core#5397), whose host pinsstellar-xdrby git rev, so the published 27.0.0 crate no longer matches —Stellar-contract.xhashes5d8063e6here vsb87e9474there — and core aborts at startup.Pins the same git rev (stellar/rs-stellar-xdr#565, where CAP-0083 and CAP-0085 were ungated) so the hashes agree. Reverts to a plain version pin once rs-stellar-xdr publishes a release carrying those changes.
Second commit is unrelated:
clippy::for_kv_mapatsrc/fbas.rs:265has failed on main since 2026-07-09 (it only fires on the newer clippy CI uses). Fixed here so this PR can go green.