ACM-26436 Remove resource limits for cluster-permission controller - #169
ACM-26436 Remove resource limits for cluster-permission controller#169mshort55 wants to merge 1 commit into
Conversation
Signed-off-by: Matthew Short <mshort@redhat.com>
|
/assign @fxiang1 |
|
|
@mshort55: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/assign @elgnay |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elgnay, mshort55 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
should we remove the limits from the upstream https://github.com/open-cluster-management-io/cluster-permission/blob/fdadfdbfba0485d6bb83001bb1629dcdf1d03ede/chart/templates/cluster-permission.yaml#L68-L70 ? |
Yes, you are right. We should update in the upstream repo and then sync to stolostron fork. |
|
Thanks, here is the new PR: open-cluster-management-io#80 |




Removed resource limits for cluster permission controller container.