Skip to content

ACM-26436 Remove resource limits for cluster-permission controller - #169

Closed
mshort55 wants to merge 1 commit into
stolostron:mainfrom
mshort55:ACM-26436
Closed

ACM-26436 Remove resource limits for cluster-permission controller#169
mshort55 wants to merge 1 commit into
stolostron:mainfrom
mshort55:ACM-26436

Conversation

@mshort55

@mshort55 mshort55 commented Dec 10, 2025

Copy link
Copy Markdown

Removed resource limits for cluster permission controller container.

Signed-off-by: Matthew Short <mshort@redhat.com>
@mshort55

Copy link
Copy Markdown
Author

/assign @fxiang1

@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
C Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@openshift-ci

openshift-ci Bot commented Dec 10, 2025

Copy link
Copy Markdown

@mshort55: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/sonarcloud 4334446 link true /test sonarcloud

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@mshort55

Copy link
Copy Markdown
Author

/assign @elgnay

@elgnay

elgnay commented Dec 11, 2025

Copy link
Copy Markdown
Collaborator

/lgtm
/approve

@openshift-ci openshift-ci Bot added the lgtm label Dec 11, 2025
@openshift-ci

openshift-ci Bot commented Dec 11, 2025

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elgnay, mshort55

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zhiweiyin318

Copy link
Copy Markdown

should we remove the limits from the upstream https://github.com/open-cluster-management-io/cluster-permission/blob/fdadfdbfba0485d6bb83001bb1629dcdf1d03ede/chart/templates/cluster-permission.yaml#L68-L70 ?
we may meet conflict when merge the codes from usptream if we change it here.

@elgnay elgnay removed the approved label Dec 11, 2025
@elgnay

elgnay commented Dec 11, 2025

Copy link
Copy Markdown
Collaborator

should we remove the limits from the upstream https://github.com/open-cluster-management-io/cluster-permission/blob/fdadfdbfba0485d6bb83001bb1629dcdf1d03ede/chart/templates/cluster-permission.yaml#L68-L70 ? we may meet conflict when merge the codes from usptream if we change it here.

Yes, you are right. We should update in the upstream repo and then sync to stolostron fork.

@mshort55 mshort55 closed this by deleting the head repository Dec 11, 2025
@mshort55

mshort55 commented Dec 11, 2025

Copy link
Copy Markdown
Author

Thanks, here is the new PR: open-cluster-management-io#80

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants