Skip to content

ACM-20548 Use shared prettier settings for react-form-wizard - #4765

Merged
KevinFCormier merged 7 commits into
stolostron:mainfrom
KevinFCormier:ACM-20548-common-prettier-settings
Jul 23, 2025
Merged

ACM-20548 Use shared prettier settings for react-form-wizard#4765
KevinFCormier merged 7 commits into
stolostron:mainfrom
KevinFCormier:ACM-20548-common-prettier-settings

Conversation

@KevinFCormier

Copy link
Copy Markdown
Contributor

📝 Summary

Ticket Summary (Title):
Changes prettier settings to use the shared ones used by all other frontend workspaces.

Ticket Link:
https://issues.redhat.com/browse/ACM-20548

Type of Change:

  • 🐞 Bug Fix
  • ✨ Feature
  • 🔧 Refactor
  • 💸 Tech Debt
  • 🧪 Test-related
  • 📄 Docs

✅ Checklist

General

  • PR title follows the convention (e.g. ACM-12340 Fix bug with...)
  • Code builds and runs locally without errors
  • No console logs, commented-out code, or unnecessary files
  • All commits are meaningful and well-labeled
  • All new display strings are externalized for localization (English only)
  • (Nice to have) JSDoc comments added for new functions and interfaces

@KevinFCormier

Copy link
Copy Markdown
Contributor Author

/hold

edewit
edewit previously approved these changes Jul 15, 2025
@openshift-ci

openshift-ci Bot commented Jul 15, 2025

Copy link
Copy Markdown

New changes are detected. LGTM label has been removed.

@openshift-ci

openshift-ci Bot commented Jul 15, 2025

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: KevinFCormier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@openshift-ci

openshift-ci Bot commented Jul 15, 2025

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: KevinFCormier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@edewit
edewit force-pushed the ACM-20548-common-prettier-settings branch from c134bed to 17efec3 Compare July 15, 2025 07:19
@KevinFCormier
KevinFCormier force-pushed the ACM-20548-common-prettier-settings branch from ce9fe5a to d624710 Compare July 22, 2025 13:56
KevinFCormier and others added 6 commits July 23, 2025 17:39
Signed-off-by: Kevin Cormier <kcormier@redhat.com>
Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com>
Signed-off-by: Kevin Cormier <kcormier@redhat.com>
Signed-off-by: Kevin Cormier <kcormier@redhat.com>
Signed-off-by: Kevin Cormier <kcormier@redhat.com>
Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com>
@KevinFCormier
KevinFCormier force-pushed the ACM-20548-common-prettier-settings branch from d624710 to 312b479 Compare July 23, 2025 21:39
Signed-off-by: Kevin Cormier <kcormier@redhat.com>
@KevinFCormier

Copy link
Copy Markdown
Contributor Author

/unhold

@sonarqubecloud

Copy link
Copy Markdown

@KevinFCormier
KevinFCormier merged commit 2b5c1a9 into stolostron:main Jul 23, 2025
8 of 9 checks passed
@KevinFCormier
KevinFCormier deleted the ACM-20548-common-prettier-settings branch July 23, 2025 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants