ACM-23852: Add repository selected validation and fix delete button in argo create application wizard.

[nitin-dhevar]

📝 Summary

Ticket Summary (Title):

ACM-23852: Add repository selected validation and fix delete button in argo create application wizard.

Ticket Link:

https://issues.redhat.com/browse/ACM-23852

Type of Change:

• 🐞 Bug Fix
• ✨ Feature
• 🔧 Refactor
• 💸 Tech Debt
• 🧪 Test-related
• 📄 Docs

---

✅ Checklist

General

• PR title follows the convention (e.g. ACM-12340 Fix bug with...)
• Code builds and runs locally without errors
• No console logs, commented-out code, or unnecessary files
• All commits are meaningful and well-labeled
• All new display strings are externalized for localization (English only)
• (Nice to have) JSDoc comments added for new functions and interfaces

If Feature

• UI/UX reviewed (if applicable)
• All acceptance criteria met
• Unit test coverage added or updated
• Relevant documentation or comments included

If Bugfix

• Root cause and fix summary are documented in the ticket (for future reference / errata)
• Fix tested thoroughly and resolves the issue
• Test(s) added to prevent regression

---

🗒️ Notes for Reviewers

[KevinFCormier]

Hey Nitin,

I don't think we should change the default behaviour of WizArrayInput to require there to be at least one entry. This affected the EditPolicy wizard, and then you had to update the test.

I also don't think we should change the Argo wizard to have Git initially selected. The user can get around this easily by editing the YAML.

I've opened a PR. What I propose is:

• Marking this particular WizArrayInput as required and only removing the Delete button for cases where at least 1 is required
• Adding a custom validation function to check if the only thing present is the placeholder empty object (from disallowEmpty)

What would still need to be done is to visually indicate when this field is required. For example, in this screenshot, you see that I cannot click Next, but there is no indication of what the validation error is. Perhaps we could indicate that where I've circled in blue?

This would be similar to when you've selected Git but not entered the URL. When collapsed, there is a validation error shown.

Alternatively, perhaps you could look into making WizTiles required.

[KevinFCormier]

Oh wow! This worked. I assumed you would need to implement this support, but glad to see it's already there.

[KevinFCormier]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: KevinFCormier, nitin-dhevar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [KevinFCormier,nitin-dhevar]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud