Fix link icon spaces

[KevinFCormier]

📝 Summary

Ticket Summary (Title):

Ticket Link:

Type of Change:

• 🐞 Bug Fix
• ✨ Feature
• 🔧 Refactor
• 💸 Tech Debt
• 🧪 Test-related
• 📄 Docs

---

✅ Checklist

General

• PR title follows the convention (e.g. ACM-12340 Fix bug with...)
• Code builds and runs locally without errors
• No console logs, commented-out code, or unnecessary files
• All commits are meaningful and well-labeled
• All new display strings are externalized for localization (English only)
• (Nice to have) JSDoc comments added for new functions and interfaces

If Feature

• UI/UX reviewed (if applicable)
• All acceptance criteria met
• Unit test coverage added or updated
• Relevant documentation or comments included

If Bugfix

• Root cause and fix summary are documented in the ticket (for future reference / errata)
• Fix tested thoroughly and resolves the issue
• Test(s) added to prevent regression

---

🗒️ Notes for Reviewers

Summary by CodeRabbit

• Style

  • Standardized documentation and external link appearance across the app; link spacing now respects a configurable top-padding to improve visual alignment.

• Refactor

  • Centralized documentation link rendering into a reusable component for more consistent behavior and maintainability.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: KevinFCormier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [KevinFCormier]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e201e939-477f-4133-8937-2c3b3000c70f

📥 Commits

Reviewing files that changed from the base of the PR and between bc9ff94 and 3f53809.

⛔ Files ignored due to path filters (1)

• frontend/src/routes/Infrastructure/Clusters/ManagedClusters/CreateClusterCatalog/common/__snapshots__/GetHostedCard.test.tsx.snap is excluded by !**/*.snap

📒 Files selected for processing (12)

• frontend/src/lib/doc-util.tsx
• frontend/src/routes/Applications/Overview.tsx
• frontend/src/routes/Home/Overview/OverviewPage.tsx
• frontend/src/routes/Infrastructure/Clusters/DiscoveredClusters/DiscoveredClusters.tsx
• frontend/src/routes/Infrastructure/Clusters/ManagedClusters/ClusterDetails/ClusterNodes/ClusterNodes.tsx
• frontend/src/routes/Infrastructure/Clusters/ManagedClusters/ClusterDetails/ClusterOverview/ClusterOverview.tsx
• frontend/src/routes/Infrastructure/Clusters/ManagedClusters/CreateClusterCatalog/CreateAWSControlPlane.tsx
• frontend/src/routes/Infrastructure/Clusters/ManagedClusters/CreateClusterCatalog/CreateControlPlane.tsx
• frontend/src/routes/Infrastructure/Clusters/ManagedClusters/CreateClusterCatalog/common/GetHostedCard.tsx
• frontend/src/routes/Infrastructure/Clusters/ManagedClusters/components/DistributionField.tsx
• frontend/src/ui-components/AcmInlineStatus/AcmInlineStatus.stories.tsx
• frontend/src/wizards/Argo/ArgoWizard.tsx

🚧 Files skipped from review as they are similar to previous changes (9)

• frontend/src/ui-components/AcmInlineStatus/AcmInlineStatus.stories.tsx
• frontend/src/routes/Applications/Overview.tsx
• frontend/src/routes/Home/Overview/OverviewPage.tsx
• frontend/src/routes/Infrastructure/Clusters/DiscoveredClusters/DiscoveredClusters.tsx
• frontend/src/wizards/Argo/ArgoWizard.tsx
• frontend/src/routes/Infrastructure/Clusters/ManagedClusters/CreateClusterCatalog/CreateAWSControlPlane.tsx
• frontend/src/routes/Infrastructure/Clusters/ManagedClusters/CreateClusterCatalog/CreateControlPlane.tsx
• frontend/src/routes/Infrastructure/Clusters/ManagedClusters/ClusterDetails/ClusterNodes/ClusterNodes.tsx
• frontend/src/lib/doc-util.tsx

---

📝 Walkthrough

Walkthrough

This PR adds an optional topPadding prop (defaulting to true) to ViewDocumentationLink and replaces many inline anchor links and direct icon usages with the reusable ViewDocumentationLink or styled AcmButton components across the frontend.

Changes

Cohort / File(s)	Summary
Core Component Enhancement frontend/src/lib/doc-util.tsx	Added optional topPadding?: boolean to ViewDocumentationLink (defaults to true) and conditionally applies padding-top when rendering.
Documentation Link Refactoring frontend/src/routes/Applications/Overview.tsx, frontend/src/routes/Home/Overview/OverviewPage.tsx, frontend/src/routes/Infrastructure/Clusters/ManagedClusters/CreateClusterCatalog/CreateAWSControlPlane.tsx, frontend/src/routes/Infrastructure/Clusters/ManagedClusters/CreateClusterCatalog/CreateControlPlane.tsx, frontend/src/routes/Infrastructure/Clusters/ManagedClusters/CreateClusterCatalog/common/GetHostedCard.tsx, frontend/src/wizards/Argo/ArgoWizard.tsx	Replaced inline anchor/link markup with ViewDocumentationLink usage; removed direct ExternalLinkAltIcon imports/usages in those spots.
UI Link Component Refactoring frontend/src/routes/Infrastructure/Clusters/DiscoveredClusters/DiscoveredClusters.tsx, frontend/src/routes/Infrastructure/Clusters/ManagedClusters/ClusterDetails/ClusterNodes/ClusterNodes.tsx, frontend/src/routes/Infrastructure/Clusters/ManagedClusters/ClusterDetails/ClusterOverview/ClusterOverview.tsx, frontend/src/routes/Infrastructure/Clusters/ManagedClusters/components/DistributionField.tsx, frontend/src/ui-components/AcmInlineStatus/AcmInlineStatus.stories.tsx	Replaced plain <a> anchors with AcmButton configured as link buttons (e.g., variant="link", component="a", isInline), preserving href, target, rel and moving icons into button props.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐰 I hopped through files with nimble feet,
Replacing anchors, making links neat.
A padding choice tucked into view,
Buttons and docs now jump in two—
Rabbity refactor, tidy and sweet! ✨

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The PR description uses the template structure but all required fields are empty or unchecked: ticket summary, ticket link, type of change, and checklist items are not populated.	Complete the template by providing the ticket summary, ticket link, selecting the type of change (appears to be a Bug Fix or Refactor), and checking relevant checklist items.
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'Fix link icon spaces' clearly summarizes the main change across the PR: removing space characters used for positioning link icons to prevent underlines.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

📝 Coding Plan

• Generate coding plan for human review comments

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.