Skip to content

ACM-30168 Add cluster TLS profile and use it for managers and webhook#1492

Merged
xiangjingli merged 2 commits intomainfrom
yupchang-tls
Mar 30, 2026
Merged

ACM-30168 Add cluster TLS profile and use it for managers and webhook#1492
xiangjingli merged 2 commits intomainfrom
yupchang-tls

Conversation

@fmt47
Copy link
Copy Markdown
Collaborator

@fmt47 fmt47 commented Mar 28, 2026

Jira ticket: https://redhat.atlassian.net/browse/ACM-30168

Introduce pkg/utils/tlsconfig to read the OpenShift cluster APIServer tlsSecurityProfile and cache a matching crypto/tls.Config for the process. Initialize that config at startup in the subscription, appsubsummary, and placementrule managers, and wire the webhook listener to use GetClusterTLSConfig(). If the APIServer resource is missing or the cluster is not OpenShift, fall back to the Intermediate TLS profile. Log profile type, MinTLSVersion, and cipher suite count after reading APIServer.

  • I have taken backward compatibility into consideration.

Introduce pkg/utils/tlsconfig to read the OpenShift cluster APIServer tlsSecurityProfile and cache a matching crypto/tls.Config for the process. Initialize that config at startup in the subscription, appsubsummary, and placementrule managers, and wire the webhook listener to use GetClusterTLSConfig(). If the APIServer resource is missing or the cluster is not OpenShift, fall back to the Intermediate TLS profile. Log profile type, MinTLSVersion, and cipher suite count after reading APIServer.

Signed-off-by: Yupeng Chang <yupchang@redhat.com>
Signed-off-by: Yupeng Chang <yupchang@redhat.com>
@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Mar 29, 2026

@fmt47: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/sonarcloud 9d4bcca link true /test sonarcloud

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@fmt47 fmt47 removed the request for review from mikeshng March 29, 2026 21:03
@xiangjingli
Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Mar 30, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fmt47, xiangjingli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xiangjingli xiangjingli merged commit e40f91f into main Mar 30, 2026
9 of 11 checks passed
@xiangjingli xiangjingli deleted the yupchang-tls branch March 30, 2026 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants