Skip to content

[release-2.12] make acm namespace env var accessible to tests (#429)#433

Open
smcavey wants to merge 1 commit intostolostron:release-2.12from
smcavey:2-12-acm-namespace-env-var
Open

[release-2.12] make acm namespace env var accessible to tests (#429)#433
smcavey wants to merge 1 commit intostolostron:release-2.12from
smcavey:2-12-acm-namespace-env-var

Conversation

@smcavey
Copy link
Copy Markdown
Contributor

@smcavey smcavey commented Sep 22, 2025

cherry-pick of #429

@smcavey
[release-2.12] make acm namespace env var accessible to tests (stolos…
569c564 
…tron#429)

* use acm namespace env var in api and ui tests

Signed-off-by: Spencer McAvey <smcavey@redhat.com>

* export ACM_NAMESPACE before tests run

Signed-off-by: Spencer McAvey <smcavey@redhat.com>

---------

Signed-off-by: Spencer McAvey <smcavey@redhat.com>
jlpadilla
jlpadilla approved these changes Sep 22, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@jlpadilla jlpadilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Sep 22, 2025
@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Sep 22, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlpadilla, smcavey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@smcavey
Copy link
Copy Markdown
Contributor Author

smcavey commented Sep 22, 2025

/retest

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Sep 22, 2025

@smcavey: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/deploy-and-run-e2e-api 569c564 link true /test deploy-and-run-e2e-api
ci/prow/deploy-and-run-e2e 569c564 link true /test deploy-and-run-e2e
ci/prow/deploy-and-run-e2e-ui 569c564 link true /test deploy-and-run-e2e-ui

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jlpadilla
Copy link
Copy Markdown
Contributor

jlpadilla commented Sep 23, 2025

@smcavey All release-2.12 PRs have been consistently failing because ACM fails installing.
The last promotion to 2.12-dev was 7 months ago!
https://github.com/stolostron/pipeline/tree/2.12-dev

@smcavey
Copy link
Copy Markdown
Contributor Author

smcavey commented Sep 23, 2025

@smcavey All release-2.12 PRs have been consistently failing because ACM fails installing. The last promotion to 2.12-dev was 7 months ago! https://github.com/stolostron/pipeline/tree/2.12-dev

@jlpadilla Do we want to:

  • change the pipeline to 2.12-integration images
  • trigger a Jenkins run against this change to verify e2e runs (would have to create a new branch in this repo since source is from my fork)
  • just send it 😎

@jlpadilla
Copy link
Copy Markdown
Contributor

jlpadilla commented Sep 26, 2025

@smcavey Sorry, I missed your last question.
The ideal solution is to have a newer snapshot promoted to 2.12-dev.
In the meantime, I'm ok with "just send it" and then validate that the tests pass on Jenkins.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jlpadilla jlpadilla jlpadilla approved these changes

Assignees

@jlpadilla jlpadilla

Labels

approved dco-signoff: yes lgtm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@smcavey @jlpadilla