Skip to content

Rosa route handling#452

Open
smcavey wants to merge 2 commits intomainfrom
rosa-route-handling
Open

Rosa route handling#452
smcavey wants to merge 2 commits intomainfrom
rosa-route-handling

Conversation

@smcavey
Copy link
Copy Markdown
Contributor

@smcavey smcavey commented Mar 30, 2026

Latest UI Cypress run against ROSA cluster failed because the console route Cypress used to verify the server was running was missing a .rosa subdomain. We fetch the proper URL from getting the route. https://redhat-internal.slack.com/archives/C0804HR2D41/p1774890605407419?thread_ts=1774890053.715339&cid=C0804HR2D41

Broken run: https://jenkins-csb-rhacm-tests.dno.corp.redhat.com/job/CI-Jobs/job/search_tests/210/console
Happy run: https://jenkins-csb-rhacm-tests.dno.corp.redhat.com/job/CI-Jobs/job/search_tests/213/console

Summary by CodeRabbit

  • Chores
    • Enhanced test configuration by implementing automatic detection of the OpenShift console environment endpoint, with graceful fallback to previously configured values if detection is unsuccessful.

smcavey added 2 commits March 30, 2026 13:33
Signed-off-by: Spencer McAvey <smcavey@redhat.com>
Signed-off-by: Spencer McAvey <smcavey@redhat.com>
@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Mar 30, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smcavey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 30, 2026

📝 Walkthrough

Walkthrough

The test script now includes logic to automatically discover the OpenShift console route by querying the console route in the openshift-console namespace. If the route is found, it updates the base URL and Cypress configuration; otherwise, it logs a warning and retains the previously configured URL.

Changes

Cohort / File(s) Summary
OpenShift Console Route Discovery
start-tests.sh
Added route discovery logic using oc get route to dynamically detect the OpenShift console host and update BASE_URL and CYPRESS_BASE_URL accordingly, with fallback to existing values on failure.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 A rabbit hops through Kubernetes clouds,
Finding console routes in namespaced shrouds,
With oc commands and jsonpath so bright,
The test script discovers its OpenShift sight! 🎉

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Rosa route handling' is directly related to the main change in the changeset, which adds OpenShift console route discovery logic to handle ROSA cluster console URLs properly.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch rosa-route-handling

Comment @coderabbitai help to get the list of available commands and usage tips.

@smcavey smcavey requested a review from jlpadilla March 30, 2026 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant