chore: sync files with stordco/common-config-elixir#13
chore: sync files with stordco/common-config-elixir#13stord-engineering-account wants to merge 1 commit intomainfrom
Conversation
Pull Request Test Coverage Report for Build 22685506968Details
💛 - Coveralls |
9dec09b to
a23158b
Compare
a23158b to
a369427
Compare
a369427 to
1b8bae0
Compare
1b8bae0 to
f2d9487
Compare
715b026 to
126222c
Compare
5c4b717 to
12de86e
Compare
12de86e to
6b6e0fb
Compare
6b6e0fb to
4fec71f
Compare
48907f0 to
7a79dd3
Compare
13401fa to
308b17f
Compare
090757b to
5b54b21
Compare
dcbc06f to
b2fce16
Compare
c0285a4 to
d711643
Compare
9bf4c03 to
31a17d2
Compare
31a17d2 to
4ef7a87
Compare
4ef7a87 to
7c58a0a
Compare
264cdcb to
ccc804e
Compare
ccc804e to
005fce4
Compare
384ddc3 to
22521dc
Compare
22521dc to
77db7eb
Compare
03b08cb to
06749fb
Compare
06749fb to
b4917b9
Compare
c015160 to
4816438
Compare
4816438 to
942da61
Compare
1384edd to
88a5c98
Compare
There was a problem hiding this comment.
Pull request overview
This PR syncs configuration files from the stordco/common-config-elixir repository, standardizing CI/CD workflows, linting rules, and security scanning across Stord's Elixir projects. The synchronization includes adding Trivy security scanning, updating GitHub Actions to SHA-pinned versions, and modernizing the release-please configuration.
Changes:
- Added Trivy security scanning with filesystem vulnerability detection and automated cache updates
- Updated all GitHub Actions to SHA-pinned versions with version comments for improved security
- Migrated release-please from v3 to v4 with updated configuration supporting hotfix and docs commit types
- Enhanced CI workflow with changed file detection to conditionally run jobs based on modified files
- Updated Credo configuration to conditionally load ExcellentMigrations checks and relaxed some readability rules
Reviewed changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
.trivy/fs-config.yaml |
New Trivy filesystem scan configuration with vulnerability severity levels |
.github/workflows/trivy.yaml |
New workflow to update Trivy vulnerability database cache daily |
.github/workflows/staging.yaml |
Updated actions to SHA-pinned versions, added MIX_ENV and actions:read permission |
.github/workflows/release.yaml |
Migrated from release-please v3 to v4, updated configuration file paths |
.github/workflows/production.yaml |
Updated checkout action to SHA-pinned v4.3.0 |
.github/workflows/pr.yaml |
Replaced custom PR title action with inline script, added hotfix and docs commit types |
.github/workflows/common-config-elixir.yaml |
Updated checkout and setup-node actions to SHA-pinned versions |
.github/workflows/ci.yaml |
Added Changed job for conditional execution, Trivy scan, SHA-pinned actions, warnings-as-errors flags |
.github/release-please-manifest.json |
New manifest file defining current version (1.0.2) |
.github/release-please-config-stable.json |
Added hotfix and docs commit types to changelog configuration |
.github/pull_request_template.md |
Added "Related Ticket(s)" section for Jira issue references |
.credo.exs |
Conditional ExcellentMigrations loading, relaxed BlockPipe and SinglePipe checks, added from to PipeChainStart exclusions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| Adding ! (i.e. \`feat!:\`) represents a breaking change and will result in a SemVer major release. | ||
|
|
||
| Starting a commit with \`hotfix\` will result in a seperate hotfix release PR. |
There was a problem hiding this comment.
Spelling error: "seperate" should be "separate". This appears in the help text that will be displayed to users when their PR title doesn't match the expected format.
| Starting a commit with \`hotfix\` will result in a seperate hotfix release PR. | |
| Starting a commit with \`hotfix\` will result in a separate hotfix release PR. |
|
|
||
| Documentation: | ||
| if: ${{ !startsWith(github.head_ref, 'release-please--branches') }} | ||
| if: ${{ !startsWith(github.head_ref, 'release-please--branches') && needs.Changed.outputs.documentation == 'true' }} |
There was a problem hiding this comment.
The Documentation job references needs.Changed.outputs.documentation on line 148, but the documentation output is commented out in the Changed job (line 40). This will cause the Documentation job's condition to always evaluate to false (or empty), which means the job will be skipped entirely. Either uncomment the output in the Changed job or remove the condition check from the Documentation job.
| if: ${{ !startsWith(github.head_ref, 'release-please--branches') && needs.Changed.outputs.documentation == 'true' }} | |
| if: ${{ !startsWith(github.head_ref, 'release-please--branches') }} |
No description provided.