Skip to content

Replaced #include "storm/.." with #include <storm/..>#399

Merged
volkm merged 5 commits into
stormchecker:masterfrom
volkm:include
May 22, 2026
Merged

Replaced #include "storm/.." with #include <storm/..>#399
volkm merged 5 commits into
stormchecker:masterfrom
volkm:include

Conversation

@volkm

@volkm volkm commented May 21, 2026

Copy link
Copy Markdown
Contributor

Fixes #231

Might need to be adapted if #367 is merged first.

@sjunges

sjunges commented May 21, 2026

Copy link
Copy Markdown
Contributor

Nice! Maybe we should have an automformat rule that there must be an empty line between a block of <> includes and "" includes? Either way, LGTM!

@volkm

volkm commented May 22, 2026

Copy link
Copy Markdown
Contributor Author

I added a rule in clang-format such that it should now enforce the following order:

#include "header.h"

#include <system-library1>
#include <system-library2>

#include "src/core/header1.h"
#include "src/core/header2.h"

Automatic sorting can be disabled by

// clang-format off
#include <storm/models/sparse/Pomdp.h>  // Must be included before verification.h
// clang-format on

@sjunges

sjunges commented May 22, 2026

Copy link
Copy Markdown
Contributor

perfect!

@volkm volkm merged commit 38d82f2 into stormchecker:master May 22, 2026
22 checks passed
@volkm volkm deleted the include branch May 22, 2026 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consistently use "" or <> in includes

2 participants