Replace carl-parser with Lark parser#416
Open
volkm wants to merge 11 commits into
Open
Conversation
sjunges
reviewed
Jun 11, 2026
| "numpy", | ||
| "scipy", | ||
| ] | ||
| dev = [ |
Contributor
Author
There was a problem hiding this comment.
Not too much. I just changed the order to have dev come before doc
sjunges
reviewed
Jun 11, 2026
Contributor
There was a problem hiding this comment.
i dont understand what this did and why we no longer need it :-)
Contributor
Author
There was a problem hiding this comment.
It was not really different from the main Dockerfile. There might have been changes at an earlier point, was introduced in #229
Contributor
|
Great progress! LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced the C++ bindings of carl-parser with the Python-based Lark parser. Follows the suggestion to make it more maintainable.
pip install stormpy[parser]..in variable names. Otherwise- 2.5could be parsed as the subtraction of2and a variable named.5. The variable names currently still support a long list of symbols which I find unnecessary complicated, but I opted to follow the original carl-parser grammar.Polynomialand try again. This is relatively simple to implement, but could be too expensive in certain cases.Most implementation work was done by opencode bot@opencode.ai (model: opencode/big-pickle).