Skip to content

Add tests for 1.3.3#481

Draft
jacqueline-57b wants to merge 1 commit intomainfrom
add-tests-1.3.3
Draft

Add tests for 1.3.3#481
jacqueline-57b wants to merge 1 commit intomainfrom
add-tests-1.3.3

Conversation

@jacqueline-57b
Copy link
Copy Markdown

@jacqueline-57b jacqueline-57b commented Dec 16, 2025

Description

Added hardhat tests for v1.3.3 changes

  • Should return false when checking if license terms with id 0 exists
  • Should retrieve license terms id with escaped URI
  • Should retrieve license terms id when URI is not set
  • Should revert registerDerivative with currency token mismatch
  • Should revert registerDerivativeWithLicenseTokens with currency token mismatch
  • Should revert predictMintingLicenseFee with invalid inputs
  • Should revert predictMintingLicenseFee when licensing hook minting fee is below license terms

Test Plan

https://github.com/storyprotocol/protocol-core-v1/actions/runs/20264244169

@wiz-6cbc7756d1
Copy link
Copy Markdown

Wiz Scan Summary

Scanner Findings
Vulnerability Finding Vulnerabilities -
Data Finding Sensitive Data -
Secret Finding Secrets -
IaC Misconfiguration IaC Misconfigurations -
SAST Finding SAST Findings 2 Low
Software Supply Chain Finding Software Supply Chain Findings -
Total 2 Low

View scan details in Wiz

To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension.

@jacqueline-57b jacqueline-57b changed the title add tests for 1.3.3 fix Add tests for 1.3.3 Dec 16, 2025
@jacqueline-57b jacqueline-57b marked this pull request as ready for review January 14, 2026 03:03
@jacqueline-57b jacqueline-57b marked this pull request as draft January 14, 2026 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant