feat: add X25519 yubikey recipient#221
Draft
dlubawy wants to merge 6 commits intostr4d:mainfrom
Draft
Conversation
|
@dlubawy there's a new prerelease of yubikey.rs, might be worth opening just the "update to latest yubikey" part of this PR as its own PR |
Author
|
@michaelbeaumont if I can find the time then I might take that up, but my focus is to get ahead of some of the recently fast moving changes in the code like the new native key support that just landed in main and over in the age-core lib. Those changes contain some more mainline support of multiple key types so I want to integrate my code better with those changes and am also selfishly looking to try adding tagged X-Wing support to my own YubiKeys. |
3dff133 to
bf883ae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support of X25519 recipients with iqlusioninc/yubikey.rs#577 being merged.
Resolves issues #174 and #185.
Builds off of #190 to get the main branch on https://github.com/iqlusioninc/yubikey.rs working. I had to squash a lot of commits to get this done which is the reason for the co-authorship on 15e1731.
Opening this as a draft because I don't believe it is immediately able to be merged due to a couple factors. For one, the code over at
yubikey.rsisn't released yet. Secondly, the new age update likely makes this code a bit more stale as the new tag recipient and PQ identities should be accounted for. Mostly opening this so the code can gain more visibility upstream of my fork and help prevent any duplication of work. Hopefully this helps out.Change tracking